A new Pull Request was created by @bsunanda (Sunanda Banerjee) for CMSSW_13_3_X.

It involves the following packages:

• DataFormats/HcalDetId (simulation)
• Geometry/ForwardGeometry (geometry)

@makortel, @bsunanda, @civanch, @cmsbuild, @mdhildreth, @Dr15Jones can you please review it and eventually sign? Thanks.
@fabiocos, @rovere, @abdoulline, @mariadalfonso, @missirol this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild Please test

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a8cc26/35646/summary.html
COMMIT: f94ab30
CMSSW: CMSSW_13_3_X_2023-11-06-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43206/35646/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 1 errors in the following unit tests:

---> test HcalPFCuts_unittest had ERRORS

Comparison Summary

Summary:

• You potentially removed 103 lines from the logs
• Reco comparison results: 136 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3363010
• DQMHistoTests: Total failures: 1789
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3361199
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 214 log files, 167 edm output root files, 50 DQM output files
• TriggerResults: no differences found

Pull request #43206 was updated. @saumyaphor4252, @perrotta, @Dr15Jones, @bsunanda, @consuegs, @cmsbuild, @mdhildreth, @francescobrivio, @civanch, @makortel can you please check and sign again.

@cmsbuild Please test

@bsunanda with your latest commit you inhibited a unit test that did not succeed: aren't you hiding possible problems, as such?
If the new output of that test is the one that must be expected, wouldn't it be preferable to modify also the reference txt file, so that the test can succeed, instead of removing the check?

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a8cc26/35659/summary.html
COMMIT: eb5d2b7
CMSSW: CMSSW_13_3_X_2023-11-06-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43206/35659/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 29 lines from the logs
• Reco comparison results: 3 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3363010
• DQMHistoTests: Total failures: 7
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3362981
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 214 log files, 167 edm output root files, 50 DQM output files
• TriggerResults: no differences found

Pull request #43206 was updated. @cmsbuild, @mdhildreth, @Dr15Jones, @makortel, @civanch, @bsunanda can you please check and sign again.

Pull request #43206 was updated. @cmsbuild, @consuegs, @perrotta, @francescobrivio, @saumyaphor4252, @mdhildreth, @civanch, @bsunanda, @Dr15Jones, @makortel can you please check and sign again.

@cmsbuild Please test

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a8cc26/35690/summary.html
COMMIT: bf01d37
CMSSW: CMSSW_13_3_X_2023-11-07-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43206/35690/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 93 lines to the logs
• Reco comparison results: 132 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3363010
• DQMHistoTests: Total failures: 2389
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3360599
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 214 log files, 167 edm output root files, 50 DQM output files
• TriggerResults: no differences found

+1

@perrotta Please sign the db part to allow the back porting

+db

• verbatim backport of Run3-hcx354 Modify the DetId fo ZDC to accommodate the changes that happened during Run3 and some provision for the future #43200 and Ignoring raw channel ids in the unit test database dump comparison #43220

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

+1